Re: [PATCH 2/2] Remove input_call_hotplug

From: Hannes Reinecke
Date: Wed Jan 19 2005 - 05:02:06 EST


Dmitry Torokhov wrote:
Hi,

On Tue, 18 Jan 2005 15:59:35 +0100, Hannes Reinecke <hare@xxxxxxx> wrote:

Implement proper class names for input drivers.



This patch probably should probably use atomic_inc in case we ever
have non-serialized probe functions.

True.

But the real question is whether we really need class devices have
unique names or we could do with inputX thus leaving individual
drivers intact and only modifying the input core. As far as I
understand userspace should be concerned only with device
capabilities, not particular name, besides, it gets PRODUCT string
which has all needed data encoded.

Indeed. What about using 'phys' (with all '/' replaced by '-') as the class_id? This way we'll retain compability with /proc/bus/input/devices and do not have to touch every single driver.

Better idea?

Cheers,

Hannes
--
Dr. Hannes Reinecke hare@xxxxxxx
SuSE Linux AG S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/