Re: [PATCH 2.6.11-rc2 06/29] ide: IDE_CONTROL_REG cleanup

[Bartlomiej Zolnierkiewicz]

On Wed, 2 Feb 2005 11:48:30 +0900, Tejun Heo <tj@xxxxxxxxxxx> wrote:
> > 06_ide_start_request_IDE_CONTROL_REG.patch
> >
> >       Replaced HWIF(drive)->io_ports[IDE_CONTROL_OFFSET] with
> >       equivalent IDE_CONTROL_REG in ide-io.c.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxxx>
> 
> Index: linux-ide-export/drivers/ide/ide-io.c
> ===================================================================
> --- linux-ide-export.orig/drivers/ide/ide-io.c  2005-02-02 10:27:15.996184821 +0900
> +++ linux-ide-export/drivers/ide/ide-io.c       2005-02-02 10:28:03.340503581 +0900
> @@ -884,7 +884,7 @@ static ide_startstop_t start_request (id
>                 if (rc)
>                         printk(KERN_WARNING "%s: bus not ready on wakeup\n", drive->name);
>                 SELECT_DRIVE(drive);
> -               HWIF(drive)->OUTB(8, HWIF(drive)->io_ports[IDE_CONTROL_OFFSET]);
> +               HWIF(drive)->OUTB(8, IDE_CONTROL_REG);
>                 rc = ide_wait_not_busy(HWIF(drive), 10000);
>                 if (rc)
>                         printk(KERN_WARNING "%s: drive not ready on wakeup\n", drive->name);

IDE_CONTROL_REG macro and co. are obfuscations and should die...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/