Re: [patch] 2.6.11-rc3-mm1: fix swsusp with gcc 3.4

[Pavel Machek]

Hi!

> > >...
> > > Changes since 2.6.11-rc2-mm2:
> > >...
> > > +swsusp-do-not-use-higher-order-memory-allocations-on-suspend.patch
> > > 
> > >  swsusp fix
> > >...
> > 
> > This broke compilation with gcc 3.4:
> [-- snip --]
> 
> BTW, it requires the following bugfix, on top of the Adrian's patch.

ACK on both patches. [The following bugfix is not that critical -- it
only leaks one page per suspend -- that's why I did not scream that
much.]
								Pavel


> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> 
> --- linux-2.6.11-rc3-mm1/kernel/power/swsusp.c	2005-02-04 22:33:52.000000000 +0100
> +++ new/kernel/power/swsusp.c	2005-02-04 22:32:36.000000000 +0100
> @@ -614,9 +614,9 @@
>  	struct pbe *pbe;
>  
>  	while (pblist) {
> -		pbe = pblist + PB_PAGE_SKIP;
> -		pblist = pbe->next;
> +		pbe = (pblist + PB_PAGE_SKIP)->next;
>  		free_page((unsigned long)pblist);
> +		pblist = pbe;
>  	}
>  }
>  
> 
> 

-- 
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/