Re: [PATCH] hid-core: Configurable USB HID Mouse Interrupt PollingInterval

[Randy.Dunlap]

Domen Puncer wrote:
> On 07/02/05 07:59 -0800, Randy.Dunlap wrote:
>
> > > +static unsigned int hid_mousepoll_interval;
> > > +module_param_named(mousepoll, hid_mousepoll_interval, uint, 0644);
> >
> > Why is it writable by root?  IOW, will writing a new value to it
> > change the operational value dynamically?
> >
> > Also, from the kernel-parameters.txt patch:
> > +	usbhid.mousepoll=
> > +		[USBHID] The interval at wich mice are to be polled at.
> >
> > (a) "which"
> > (b) drop one of the "at"s... either one.
>
>
> Is listing module parameters in kernel-parameters.txt the right thing
> to do? (There are lots of them, not many are listed)

It's currently the right thing to do, but some automated overhaul
sure would make sense.

> I see some options that might be better:
> - Kconfig magic which extracts module_param* and MODULE_PARM_DESC from
>   sources and appends them to help text.
> - a userspace script, that goes trough all modules and generates
>   kernel-module-parameters.txt for example.
> - modinfo like tool (but i think it would require source or descriptions
>   compiled in kernel)

--
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/