[2.6 patch] drivers/net/lp486e.c: make some code static

[Adrian Bunk]

On Sun, Feb 20, 2005 at 08:47:14PM -0500, Jeff Garzik wrote:
>...
> >+#if 0
> >+static char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", 
> >"MulticastList",
> >+			       "Tx", "TDR", "Dump", "Diagnose" };
> >+#endif
> 
> Need const.


Updated patch:


<--  snip  -->


This patch makes some needlessly global code static and makes
CUcmdnames const.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

---

 drivers/net/lp486e.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

--- linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c.old	2005-02-16 16:08:34.000000000 +0100
+++ linux-2.6.11-rc3-mm2-full/drivers/net/lp486e.c	2005-02-16 16:15:33.000000000 +0100
@@ -112,8 +112,10 @@
 	CmdDiagnose = 7
 };
 
-char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
-			"Tx", "TDR", "Dump", "Diagnose" };
+#if 0
+static const char *CUcmdnames[8] = { "NOP", "IASetup", "Configure", "MulticastList",
+				     "Tx", "TDR", "Dump", "Diagnose" };
+#endif
 
 /* Status word bits */
 #define	STAT_CX		0x8000	/* The CU finished executing a command
@@ -960,7 +962,7 @@
 		(unsigned char) add[12], (unsigned char) add[13]);
 }
 
-int __init lp486e_probe(struct net_device *dev) {
+static int __init lp486e_probe(struct net_device *dev) {
 	struct i596_private *lp;
 	unsigned char eth_addr[6] = { 0, 0xaa, 0, 0, 0, 0 };
 	unsigned char *bios;


-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html