Re: [PATCH: 2.6.11-rc5] i2c chips: ds1337 RTC driver

[Greg KH]

On Mon, Feb 28, 2005 at 05:14:25PM +0000, James Chapman wrote:
> +/* Define to compile in pr_debug() trace */
> +#undef DEBUG

Not needed, we do this in the makefile now.

> +	if (debug >= 1)
> +		pr_debug("%s: client=%p, dt=%p\n", __FUNCTION__, client, dt);

Please use the dev_dbg(), dev_err() and friend functions instead of
pr_debug().  It provides a sane user interface that all of the other
drivers use.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/