Re: v2.4 megaraid2 update Re: [PATCH] Prevent NMI oopser

From: Marcelo Tosatti
Date: Wed Mar 02 2005 - 20:40:31 EST


On Wed, Mar 02, 2005 at 11:26:06AM -0500, Bagalkote, Sreenivas wrote:
> Hello Marcelo,

Hi Sreenivas,

Damn, now I apologize for taking so long to answer...

> As per our offline conversation, I have verified the update that went into
> 2.4.30-pre2.
> I confirm that all changes are correct. I have only one doubt: The driver
> was using
> sleep_on_timeout for lack of msleep. Should it start using msleep now?

I dont see the need for msleep() given that sleep_on_timeout() schedules.

The problematic EH code which used udelay() was removed AFAICS.

> Vasily & Andrey, thank you for your efforts.

I appreciate your offline message that you're compromised to
keep an eye on v2.4 megaraid2 from now on :)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/