Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

[Adrian Bunk]

On Wed, Mar 02, 2005 at 01:18:17PM -0800, Andrew Morton wrote:
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
> >
> > > Thing is, CRYPTO_AES on only selectable on x86.
> > 
> >  You're thinking about CRYPTO_AES_586.  But looking at crypto/Kconfig, 
> >  the dependencies are a bit weird:
> > 
> >  config CRYPTO_AES
> >           tristate "AES cipher algorithms"
> >           depends on CRYPTO && !(X86 && !X86_64)
> >  config CRYPTO_AES_586
> >           tristate "AES cipher algorithms (i586)"
> >           depends on CRYPTO && (X86 && !X86_64)
> 
> That's pretty broken, isn't it?
> 
> Would be better to just do:
> 
> config CRYPTO_AES
> 	select CRYPTO_AES_586 if (X86 && !X86_64)
> 	select CRYPTO_AES_OTHER if !(X86 && !X86_64)
> 
> and hide CRYPTO_AES_586 and CRYPTO_AES_OTHER from the outside world.


  http://www.ussg.iu.edu/hypermail/linux/kernel/0502.3/0518.html
  http://www.ussg.iu.edu/hypermail/linux/kernel/0502.3/0523.html
  

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/