Re: [PATCH 1/2] BDI: Provide backing device capability information

[David Howells]

Andrew Morton <akpm@xxxxxxxx> wrote:

> 
> > +#define BDI_CAP_MAP_COPY	0x00000001	/* Copy can be mapped (MAP_PRIVATE) */
> > +#define BDI_CAP_MAP_DIRECT	0x00000002	/* Can be mapped directly (MAP_SHARED) */
> 
> Why not make these bitfields as well?

Because I want to copy the capabilities mask (including these variables) into
a variable in the nommu mmap implementation and eliminate various bits from
that variable under certain conditions.

Making these into bitfields would result in having to use three variables
instead of just the one.

David

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/