Re: [PATCH][3/26] IB/mthca: improve CQ locking part 1

[Greg KH]

On Thu, Mar 03, 2005 at 07:35:00PM -0500, Jeff Garzik wrote:
> Roland Dreier wrote:
> >@@ -783,6 +777,11 @@
> > 			  cq->cqn & (dev->limits.num_cqs - 1));
> > 	spin_unlock_irq(&dev->cq_table.lock);
> > 
> >+	if (dev->mthca_flags & MTHCA_FLAG_MSI_X)
> >+	 synchronize_irq(dev->eq_table.eq[MTHCA_EQ_COMP].msi_x_vector);
> >+	else
> >+		synchronize_irq(dev->pdev->irq);
> >+
> 
> 
> Tangent:  I think we need a pci_irq_sync() rather than putting the above 
> code into each driver.

Sure, I have no problem accepting that into the pci core.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/