Re: [PATCH/RFC] I/O-check interface for driver's error handling

[Hidetoshi Seto]

Linas Vepstas wrote:
> > If their defaults are no-ops, device
> > maintainers who develops their driver on not-implemented arch should be
> > more careful. 
>
> Why? People who write device drivers already know if/when they need to
> disable interrupts, and so they already disable if they need it.  

OK, I'll remake them as no-ops.
Nothing will start unless trust in driver folks.

> p.s. I would like to have iochk_read() take struct pci_dev * as an
> argument.  (I could store a pointer to pci_dev in the "cookie" but
> that seems odd).

I'd like to store the pointer and handle all only with the cookie...
Or is it needed to pass different device to iochk_clear() and iochk_read()?


Thanks,
H.Seto

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/