Re: [2.6 patch] unexport complete_all

[mike]

> On Fri, Mar 04, 2005 at 03:09:39AM -0500, Mike Waychison wrote:
>> > I didn't find any possible modular usage in the kernel.
>> >
>> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
>> >
>> > --- linux-2.6.11-rc5-mm1-full/kernel/sched.c.old	2005-03-04
>> 01:04:28.000000000 +0100
>> > +++ linux-2.6.11-rc5-mm1-full/kernel/sched.c	2005-03-04
>> 01:04:34.000000000 +0100
>> > @@ -3053,7 +3053,6 @@
>> >  			 0, 0, NULL);
>> >  	spin_unlock_irqrestore(&x->wait.lock, flags);
>> >  }
>> > -EXPORT_SYMBOL(complete_all);
>> >
>> >  void fastcall __sched wait_for_completion(struct completion *x)
>> >  {
>> > -
>>
>> This is a valid piece of API that is exported for future use.
>>...
>
> You exported this function nearly one year ago with the only comment
> "Export complete_all for module use.".
>
> Why did you add the export last year instead of simply adding it when it
> will be required?
>

Because it makes no sense to export only part of an API-set.  A good
interface should be as consistent as possible; selectively choosing what
is available for modular use fails this requirement.

The original patch was sent as I believed the lack of an exported
complete_all was purely an oversight.

Mike Waychison

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/