Re: [PATCH] 2.6.11-mm1 "nobh" support for ext3 writeback mode

[Badari Pulavarty]

On Fri, 2005-03-04 at 16:45, Andrew Morton wrote:
> Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:
> >
> > > What's all this doing?  (It needs comments please - it's very unobvious).
> > 
> > All its trying to do is - to make sure the page is uptodate so that
> > it can zero out the portion thats needed. 
> 
> OK.
> 
> > I can do getblock() and ll_rw_block(READ) instead. I was
> > trying to re-use the code and mpage_readpage() drops the lock.
> > What do you think ?
> 
> Can you just call ->prepare_write, as nobh_truncate_page() does?  That'll
> cause a nested transaction, but that's legal.
> 

Thats what I tried earlier, but never got it working. Lots of journal
asserts :( 

I guess I really need to learn journaling code someday.

Thanks,
Badari

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/