Re: [2.6 patch] mm/swap_state.c: unexport swapper_space

[Christoph Hellwig]

On Sun, Mar 06, 2005 at 03:28:19PM +0000, Hugh Dickins wrote:
> immediately on demand).  It's used by the inline page_mapping() in
> include/linux/mm.h, which _was_ used by various arch cacheflushing
> inlines, which could reasonably be called from modular filesystems.
> 
> I think those architectures hit the missed export when the dependence
> on &swapper_space got added to page_mapping(), the export was soon
> added to mainline, but meanwhile they moved their inlines out-of-line
> - perhaps temporarily, but not yet reverted.
> 
> Better leave it exported so long as page_mapping is using it.

I disagree.  swapper_state is far too much of an internal detail to be
exported.  I argued that way when page_mapping was changed to use it and
that's why the architectures moved their helpers out of line.
Looks like the exported unfortunately got added anyway although we settled
that discussion.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/