Re: [patch 1/8] isdn_bsdcomp.c - vfree() checking cleanups

[Domen Puncer]

On 07/03/05 00:07 +0000, Ralph Corderoy wrote:
> 
> Hi Domen,
> 
> > -		if (db->dict) {
> > -			vfree (db->dict);
> > -			db->dict = NULL;
> > -		}
> > +		vfree (db->dict);
> > +		db->dict = NULL;
> 
> Is it really worth always calling vfree() which calls __vunmap() before
> db->dict is determined to be NULL in order to turn three lines into two?

Four lines into two :-)

> Plus the write to db->dict which might otherwise not be needed.  The old
> code was clear, clean, and fast, no?

Shorter and more readable code is always better, right? And speed really
doesn't seem to be an issue here.


	Domen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/