Re: New ALPS code in -mm

[Vojtech Pavlik]

On Mon, Mar 07, 2005 at 02:14:17AM -0500, Daniel Barkalow wrote:

> On Fri, 4 Mar 2005, Vojtech Pavlik wrote:
> 
> >  		/* Relative movement packet */
> >   		if (z == 127) {
> > -			input_report_rel(dev2, REL_X,  (x > 383 ? x : (x - 768)));
> > -			input_report_rel(dev2, REL_Y, -(y > 255 ? y : (x - 512)));
> > +			input_report_rel(dev2, REL_X,  (x > 383 ? (x - 768) : x));
> > +			input_report_rel(dev2, REL_Y, -(y > 255 ? (x - 512) : y));
> 
> Not that I have any idea, but (y - 512) seems much more likely here.
> 
> > +	if ((priv->i->flags & ALPS_DUALPOINT) && z == 127) {
> > +		input_report_key(dev2, BTN_LEFT,   left);    
> > +		input_report_key(dev2, BTN_RIGHT,  right);
> > +		input_report_key(dev2, BTN_MIDDLE, middle);
> > +		input_report_rel(dev2, REL_X,  (x > 383 ? (x - 768) : x));
> > +		input_report_rel(dev2, REL_Y, -(y > 255 ? (x - 512) : y));
> 
> Also here.
 
Indeed. It took me a while to find it.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/