Re: [PATCH 1/2] BDI: Provide backing device capability information

[David Howells]

Miklos Szeredi <miklos@xxxxxxxxxx> wrote:

> > It shouldn't silently break... It will refuse to compile. I renamed
> > "memory_backed" to "capabilities".
> 
> This will silently break:
> 
> static struct backing_dev_info my_bdi = {
>        .ra_pages = MY_RA,
>        .unplug_io_fn = default_unplug_io_fn,
> };

Sorry, yes. Obvious. Ugh. Andrew Morton suggested flipping the logic, and
although it was in conjunction with turning the concepts into bitfields, it
still stands here.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/