Re: 2.6.11-mm1: sound <-> GAMEPORT problems

[Dmitry Torokhov]

On Mon, 7 Mar 2005 22:52:06 +0100, Adrian Bunk <bunk@xxxxxxxxx> wrote:
> On Mon, Mar 07, 2005 at 09:41:59AM +0100, Borislav Petkov wrote:
> > On Friday 04 March 2005 12:32, Andrew Morton wrote:
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11/2.6.11
> > >-mm1/
> > >
> > <snip>
> >
> > Hi,
> >
> > the ymfpci sound driver wouldn't compile without gameport support selected
> > since the sound card has a gameport on it:
> >
> > Signed-off-by: Borislav Petkov <petkov@xxxxxxxxxxxxxxx>
> >
> > --- sound/pci/ymfpci/ymfpci.c.orig 2005-03-07 09:07:10.000000000 +0100
> > +++ sound/pci/ymfpci/ymfpci.c 2005-03-07 09:08:02.000000000 +0100
> > @@ -332,7 +332,9 @@ static int __devinit snd_card_ymfpci_pro
> >    }
> >   }
> >
> > +#ifdef SUPPORT_JOYSTICK
> >   snd_ymfpci_create_gameport(chip, dev, legacy_ctrl, legacy_ctrl2);
> > +#endif /* SUPPORT_JOYSTICK */
> >
> >   if ((err = snd_card_register(card)) < 0) {
> >    snd_card_free(card);
> 
> Nice catch (but I had to apply the patch manually due to some
> whitespace damage).
> 
> After a quick look, it seems there are a dozen other sound drivers (most
> OSS but also ALSA) with similar problems.
> 
> There are two possibilities:
> 1. continue to #ifdef all GAMEPORT support in sound drivers
> 2. remove all #ifdef's for GAMEPORT and let drivers that can use the
>   gameport (including the sound drivers) simply select GAMEPORT
>   As far as I can see, in this case GAMEPORT does no longer have to be
>   user-visible?
> 
> I can send patches for both, but I'd prefer the second solution.
> 

Not everyone wants gameport. I think say very small percentage of
people using sound cards that can support gameports actually uses
them.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/