Re: [PATCH] Restore PWC driver

From: Greg KH
Date: Tue Mar 08 2005 - 00:29:20 EST

On Mon, Mar 07, 2005 at 09:49:40PM +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.1982.132.4, 2005/03/07 13:49:40-08:00, alan@xxxxxxxxxxxxxxxxxxx
> [PATCH] Restore PWC driver
> PWC has a new maintainer (Luc Saillard) and also the various contentious
> binary hooks removed and replaced with reverse engineering work.
> Please restore it to the kernel

Ick, Alan, couldn't you have had the decency to run this through the USB
developers, and at least pinged me on it? Especially due to all of the
hate-email I have gotten over this driver in the past.

As it is, the coding style sucks in places, and you didn't really need
to make it a new subdirectory (although due to the increased size of the
driver, it's probably better now...)

And, there's no MAINTAINERS entry for who I need to bug about this


So, who's going to fix up:
- the MAINTAINERS entry
- the coding style
- drop that unneeded changelog file
- fix the module help text to point to the proper file (or put
the file in the proper place.)
- get rid of the c++ crud in the header file
- drop the "magic" nonsense
- the ioctls to work on 64bit machines

And I found all of that in just a quick glance over the code...

Double bleah.

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at