Re: Fix suspend/resume problems with b44

From: Pavel Machek
Date: Tue Mar 08 2005 - 16:56:28 EST


Hi!

> > @@ -1934,6 +1936,9 @@
> > if (!netif_running(dev))
> > return 0;
> >
> > + if (request_irq(dev->irq, b44_interrupt, SA_SHIRQ, dev->name, dev))
> > + printk(KERN_ERR PFX "%s: request_irq failed\n", dev->name);
> > +
>
> This is a hard error and means that bringup of the chip
> will totally fail. It definitely deserves something harder
> than a printk(), but unfortunately ->resume() has no way
> to cleanly fail.

Any idea what to do there? I'd say that request_irq is very unlikely
to fail given that it worked okay before suspend...
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html