RE: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new module for LSI Logic's SAS based MegaRAID controllers

[Arjan van de Ven]

On Tue, 2005-03-08 at 18:08 -0500, Bagalkote, Sreenivas wrote:
> 
> I will make this an instance parameter if the idea to reduce as many
> global variables as possible. But if the objection is because each
> adapter
> may have different value for variable, then it is indeed a global
> value.
> "is_dma64" - which is computed using the size of dma_addr_t - is
> telling
> something about the kernel rather than the controller feature.
> 

then having it as variable sounds really really wrong; the size of
dma_addr_t is a compile time property...
(and why do you care about it? you see high dma addresses when they come
in, right?)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/