Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

[Chris Wright]

* Jean Delvare (khali@xxxxxxxxxxxx) wrote:
> Hi all,
> 
> While working on the saa7110 driver I found a problem with the way
> various video drivers (found on Zoran-based boards) prepare i2c messages
> to be used by i2c_transfer. The drivers improperly copy the i2c client
> flags as the message flags, while both sets are mostly unrelated. The
> net effect in this case is to trigger an I2C block read instead of the
> expected I2C block write. The fix is simply not to pass any flag,
> because none are needed.
> 
> I think this patch qualifies hands down as a "critical bug fix" to be
> included in whatever bug-fix-only trees exist these days. As far as I
> can see, all Zoran-based boards are broken in 2.6.11 without this patch.

Are people reporting this as a problem?

-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/