Re: [01/11] fix amd64 2.6.11 oops on modprobe (saa7110)

From: Josh Boyer
Date: Thu Mar 10 2005 - 20:42:03 EST


On Thu, 2005-03-10 at 15:07 -0800, Greg KH wrote:
> -stable review patch. If anyone has any objections, please let us know.
>
> ------------------
>
> This is a rewrite of the saa7110_write_block function, which was plain
> broken in the case where the underlying adapter supports I2C_FUNC_I2C.
> It also includes related fixes which ensure that different parts of the
> driver agree on the number of registers the chip has.
>
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Signed-off-by: Chris Wright <chrisw@xxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
> --- linux-2.6.11-bk3/drivers/media/video/saa7110.c.orig Tue Mar 8 10:27:15 2005
> +++ linux-2.6.11-bk3/drivers/media/video/saa7110.c Tue Mar 8 12:02:45 2005
> @@ -58,10 +58,12 @@
> #define SAA7110_MAX_INPUT 9 /* 6 CVBS, 3 SVHS */
> #define SAA7110_MAX_OUTPUT 0 /* its a decoder only */
>
> -#define I2C_SAA7110 0x9C /* or 0x9E */
> +#define I2C_SAA7110 0x9C /* or 0x9E */

Not that I really care, but isn't there a rule that a patch "... can not
contain any "trivial" fixes in it (spelling changes, whitespace
cleanups, etc.)"?

josh


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/