Re: [patch] Real-Time Preemption, -RT-2.6.11-rc3-V0.7.38-01

From: Ingo Molnar
Date: Fri Mar 11 2005 - 05:20:33 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> > > Doing a quick search on the kernel, it looks like only kjournald uses
> > > the bit_spin_locks. I'll start converting them to spinlocks. The use
> > > seems to be more of a hack, since it is using bits in the state field
> > > for locking, and these bits aren't used for anything else.
> >
> > yeah. bit-spinlocks are really a hack.
>
> And this really sucks too! I've been looking into a fix for this and
> have yet to get something stable. As you probably already know, you
> can't just put back the preempt_disable since your spinlocks now
> schedule. So I've been looking into finding a way to get rid of these.
>
> I've tried making two global spinlocks, one for the state bit and one
> for the journal head bit use. But this deadlocks with j_state_lock.
> The journal head lock seems to be ok to be global, but the state lock
> needs to have one for every buffer head. I'm now hacking away to do
> this without touching the actual buffer head. But I'm not sure what
> some of the side effects this is having. I'll keep you posted when I
> get something working. I'm now having a crash course in how kjournal
> and friends work.

did you try the canonical way of putting a spinlock into every
buffer_head?

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/