Re: [patch] w6692 eliminate bad section references

[maximilian attems]

On Mon, 14 Mar 2005, Randy.Dunlap wrote:

> maximilian attems wrote:
> >Fix w6692 section references:
> >  convert __initdata to __devinitdata.
> >
> >Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32
> >.init.data
> >
> I think the correct fix is to make W6692Version() be __init ...
> What do you think of that?
> 
> -- 
> ~Randy

thanks a lot for your review!
you are right much better, added __init to W6692Version().

#Signed-off-by: maximilian attems <janitor@xxxxxxxxxxxxxx>

diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c
linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c
--- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c	2005-03-02 08:38:25.000000000 +0100
+++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c	2005-03-15 14:01:14.000000000 +0100
@@ -49,7 +49,7 @@ static char *W6692Ver[] __initdata =
 {"W6692 V00", "W6692 V01", "W6692 V10",
  "W6692 V11"};
 
-static void
+static void __init
 W6692Version(struct IsdnCardState *cs, char *s)
 {
 	int val;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/