Re: [2/9] Possible AMD8111e free irq issue

[Jeff Garzik]

Ian Pilcher wrote:
> Chris Wright wrote:
>
> > From: Andres Salomon <dilinger@xxxxxxxxxx>
> >
> > It seems to me that if in the amd8111e_open() fuction dev->irq isn't
> > zero and the irq request succeeds it might not get released anymore.
>
> Based on the wording above, I can't help wondering if this fixes a
> problem that anyone is actually seeing.


Maybe the wording is wrong, but the patch fixes an obvious 
leak-on-error.  Allocations in amd8111e_init_ring() could certainly fail.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/