[2.6 patch] drivers/net/tulip/dmfe.c: fix check after use

From: Adrian Bunk
Date: Thu Mar 24 2005 - 20:51:38 EST


This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>

--- linux-2.6.12-rc1-mm1-full/drivers/net/tulip/dmfe.c.old 2005-03-23 05:05:36.000000000 +0100
+++ linux-2.6.12-rc1-mm1-full/drivers/net/tulip/dmfe.c 2005-03-23 05:06:00.000000000 +0100
@@ -736,20 +736,22 @@

static irqreturn_t dmfe_interrupt(int irq, void *dev_id, struct pt_regs *regs)
{
struct DEVICE *dev = dev_id;
struct dmfe_board_info *db = netdev_priv(dev);
- unsigned long ioaddr = dev->base_addr;
+ unsigned long ioaddr;
unsigned long flags;

DMFE_DBUG(0, "dmfe_interrupt()", 0);

if (!dev) {
DMFE_DBUG(1, "dmfe_interrupt() without DEVICE arg", 0);
return IRQ_NONE;
}

+ ioaddr = dev->base_addr;
+
spin_lock_irqsave(&db->lock, flags);

/* Got DM910X status */
db->cr5_data = inl(ioaddr + DCR5);
outl(db->cr5_data, ioaddr + DCR5);

-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html