Re: [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

[Christoph Hellwig]

I took a quick look an a here's a few comments:

 - I don't think renaming mptscsih.c to mpt_core.c makes sense.
   the new name is confusing at best, and keeping the old name allows
   to keep SCCS history aswell.  That means the new SPI stub driver should
   be called mptspi or something like that.
 - please don't link mpt_core.o into both mptfch.ko and mptscsih.ko but
   make it a module of it's own
 - the new driver shoild use module_param, not MODULE_PARM
 - why does the fc driver set ioc->spi_data.mpt_pq_filter?
 - no need to forward-declare the module_init/module_exit handlers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/