Re: [PATCH scsi-misc-2.6 02/13] scsi: don't turn on REQ_SPECIAL on sgtable allocation failure.

From: Tejun Heo
Date: Thu Mar 31 2005 - 04:20:22 EST


02_scsi_no_REQ_SPECIAL_on_sgtable_allocation_failure.patch

Don't turn on REQ_SPECIAL on sgtable allocation failure. This
was the last place where REQ_SPECIAL is turned on for normal
requests.

Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>

scsi_lib.c | 4 +---
1 files changed, 1 insertion(+), 3 deletions(-)

Index: scsi-export/drivers/scsi/scsi_lib.c
===================================================================
--- scsi-export.orig/drivers/scsi/scsi_lib.c 2005-03-31 18:06:19.000000000 +0900
+++ scsi-export/drivers/scsi/scsi_lib.c 2005-03-31 18:06:20.000000000 +0900
@@ -940,10 +940,8 @@ static int scsi_init_io(struct scsi_cmnd
* if sg table allocation fails, requeue request later.
*/
sgpnt = scsi_alloc_sgtable(cmd, GFP_ATOMIC);
- if (unlikely(!sgpnt)) {
- req->flags |= REQ_SPECIAL;
+ if (unlikely(!sgpnt))
return BLKPREP_DEFER;
- }

cmd->request_buffer = (char *) sgpnt;
cmd->request_bufflen = req->nr_sectors << 9;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/