Re: [PATCH scsi-misc-2.6 05/13] scsi: remove a timer race from scsi_queue_insert() and cleanup timer

From: Christoph Hellwig
Date: Thu Mar 31 2005 - 05:17:43 EST


> /* Queue the command and wait for it to complete */
> /* Abuse eh_timeout in the scsi_cmnd struct for our purposes */
> init_timer(&cmd->eh_timeout);
> + cmd->eh_timeout.function = NULL;

I'd rather not see aic7xxx poke even deeper into this internal code.
Can you please switch it to use a timer of it's own first?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/