Re: [patch 2/3] x86_64: remove duplicated sys_time64

[Andi Kleen]

On Wed, Mar 30, 2005 at 07:32:16PM +0200, blaisorblade@xxxxxxxx wrote:
> 
> CC: Andi Kleen <ak@xxxxxxx>
> 
> Keeping this function does not makes sense because it's a copied (and buggy)
> copy of sys_time. The only difference is that now.tv_sec (which is a time_t,
> i.e. a 64-bit long) is copied (and truncated) into a int (32-bit).
> 
> The prototype is the same (they both take a long __user *), so let's drop this
> and redirect it to sys_time (and make sure it exists by defining
> __ARCH_WANT_SYS_TIME).
> 
> Only disadvantage is that the sys_stime definition is also compiled (may be
> fixed if needed by adding a separate __ARCH_WANT_SYS_STIME macro, and defining
> it for all arch's defining __ARCH_WANT_SYS_TIME except x86_64).
> 
> Not compile-tested, sorry.


Nack. The generic sys_time still writes to int, not long.
That is why x86-64 has a private one. Please keep that.


-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/