Re: connector.c

[Tommy Reynolds]

Uttered Andrew Morton <akpm@xxxxxxxx>, spake thus:

> > 	if (uskb) {
> > 		netlink_unicast(dev->nls, uskb, 0, 0);
> > 	}
> 
> Unneeded {}

Speaking strictly as a language lawyer, they are not needed.

However, for maintainability (and best practices) they are essential.
They make the scope of the test explicit and ensure that a one-line-
change really doesn't affect more lines that needed.  Think context
diffs here.

Cheers!

Attachment: pgp00000.pgp
Description: PGP signature