Re: [RFC][PATCH] timers fixes/improvements

[Ingo Molnar]

* Oleg Nesterov <oleg@xxxxxxxxxx> wrote:

> struct timer_list {
> 	...
> 	timer_base_t *_base;
> };

namespace cleanliness: i'd suggest s/_base/base.

another detail:

> int __mod_timer(struct timer_list *timer, unsigned long expires)
[...]
> 		/* Ensure the timer is serialized. */
> 		if (base != &new_base->t_base
> 			&& base->running_timer == timer)
> 			goto unlock;

> unlock:
> 		spin_unlock_irqrestore(&base->lock, flags);
> 	} while (ret < 0);

so we keep looping in __mod_timer() when the timer is running? Couldnt 
this be a performance hit?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/