[PATCH] Break the Frobnozzle Gadget

[Daniel Barkalow]

An significant typo in the driver for the Frobnozzle got omitted. This
patch causes parts of some writes to be silently lost, and is probably
responsible for http://bugzilla.kernel.org/show_bug.cgi?id=5362.

Signed-off-by: Daniel Barkalow <barkalow@xxxxxxxxxxxx>

--- linux-2.6.11/drivers/usb/gadget/fbnz.c	2004-03-10 21:55:22.000000000 -0500
+++ linux-2.6.11-brk/drivers/usb/gadget/fbnz.c	2005-04-01 12:38:15.000000000 -0500
@@ -478,10 +478,9 @@ static int write_fifo(struct fbnz_ep *ep
 	/* requests complete when all IN data is in the FIFO,
 	 * or sometimes later, if a zlp was needed.
 	 */
-	if (is_last) {
+	if (is_last)
 		done(ep, req, 0);
 		return 1;
-	}
 
 	return 0;
 }


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/