[PATCH] drivers/pci/hotplug/cpqphp_core.c: fix a check after use

[Greg KH]

ChangeSet 1.2181.16.20, 2005/03/28 15:10:15-08:00, bunk@xxxxxxxxx

[PATCH] drivers/pci/hotplug/cpqphp_core.c: fix a check after use

This patch fixes a check after use found by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>


 drivers/pci/hotplug/cpqphp_core.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff -Nru a/drivers/pci/hotplug/cpqphp_core.c b/drivers/pci/hotplug/cpqphp_core.c
--- a/drivers/pci/hotplug/cpqphp_core.c	2005-04-01 15:33:05 -08:00
+++ b/drivers/pci/hotplug/cpqphp_core.c	2005-04-01 15:33:05 -08:00
@@ -577,10 +577,10 @@
 {
 	u8 hp_slot;
 
-	hp_slot = func->device - ctrl->slot_device_offset;
-
 	if (func == NULL)
 		return(1);
+
+	hp_slot = func->device - ctrl->slot_device_offset;
 
 	// Wait for exclusive access to hardware
 	down(&ctrl->crit_sect);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/