Re: [PATCH] Direct IO async short read bug followup

[Andrew Morton]

Daniel McNeil <daniel@xxxxxxxx> wrote:
>
> I updated the patch to add an i_size element to the dio structure and
>  sample i_size during i/o submission.  When i/o completes the result can
>  be truncated to match the file size without using i_size_read(), thus
>  the aio result now matches the number of bytes read to the end of file.
> 

Can you provide the analysis of the bug, please?

> 
>  Daniel
> 
>  --- linux-2.6.11.orig/fs/direct-io.c	2005-04-01 15:33:11.000000000 -0800
>  +++ linux-2.6.11/fs/direct-io.c	2005-03-31 16:59:15.000000000 -0800
>  @@ -66,6 +66,7 @@ struct dio {
>   	struct bio *bio;		/* bio under assembly */
>   	struct inode *inode;
>   	int rw;
>  +	ssize_t i_size;			/* i_size when submitted */

I'll change this to loff_t, OK?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/