Re: [RFC][PATCH] timers fixes/improvements

[Andrew Morton]

Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
> +void fastcall init_timer(struct timer_list *timer)
>  +{
>  +	timer->entry.next = NULL;
>  +	timer->_base = &per_cpu(tvec_bases,
>  +			__smp_processor_id()).t_base;
>  +	timer->magic = TIMER_MAGIC;
>  +}

__smp_processor_id() is not implemented on all architectures.  I'll switch
this to _smp_processor_id().

The smp_processor_id() stuff is all rather a twisty maze (looks at Ingo).

It's a rather odd thing which you're doing there.  Why does a
not-yet-scheduled timer need a ->_base?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/