Re: [Fwd: Re: connector is missing in 2.6.12-rc2-mm1]

[Andrew Morton]

Evgeniy Polyakov <johnpol@xxxxxxxxxxx> wrote:
>
> > 
> > Plus, I'm still quite unsettled about the whole object lifecycle
> > management, refcounting and locking in there.  The fact that the code is
> > littered with peculiar barriers says "something weird is happening here",
> > and it remains unobvious to me why such a very common kernel pattern was
> > implemented in such an unusual manner.
> > 
> > So.  I'd like to see the whole thing reexplained and resubmitted so we can
> > think about it all again.
> 
> All those barriers can be replaced with atomic_dec_and_test(), 

What a shame you didn't say atomic_dec_and_lock()...

> i.e. with something that returns the value.
> Methods that return value requires explicit barriers.
> 
> Actually there are quite many places where we have:
> 
> cpu0                             cpu1
> use object
> atomic_dec()
>                                  if atomic_read/atomic_dec_and_test == 0
>                                     free object.

Yes, but those places normally also use locking to prevent the obvious race.

Yes, atomic_dec_and_test() and barrier removal would be better.  Especially
if it's associated with code commentary which explains why the whole thing
isn't racy (ie: explains why no other CPU can look this object up).

> > Which comments were not addressed?
> 
> CBUS code comments [I did not get ack on CBUS itself], and two below
> issues.

I continue to not see any point in cbus.  It moves work from one place to
another while increasing the amount of code and quite probably increasing
the net amount of work too.

IOW it looks like a net loss which happens to provide gains in one rather
uninteresting microbenchmark.

I'll gleefully admit that I'm wrong, but I don't think that has been
demonstrated yet.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/