Re: [PATCH][RFC] disable built-in modules V2

[Horst von Brand]

AsterixTheGaul <asterixthegaul@xxxxxxxxx> said:
> > -#define module_init(x) __initcall(x);
> > +#define module_init(x) __initcall(x); __module_init_disable(x);
> 
> It would be better if there is brackets around them... like
> 
> #define module_init(x) { __initcall(x); __module_init_disable(x); }
> 
> then we know it wont break some code like
> 
> if (..)
>  module_init(x);

But happily break:

   if (...)
    module_init(x);
   else
    ...

This should be:

#define module_init(x)  do {__initcall(x); __module_init_disable(x);}while(0)
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                     Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria              +56 32 654239
Casilla 110-V, Valparaiso, Chile                Fax:  +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/