Re: Re: Re: Re: [ANNOUNCE] git-pasky-0.1

[Linus Torvalds]

On Mon, 11 Apr 2005, Petr Baudis wrote:
> 
> (BTW, it would be useful to have a tool which just blindly takes what
> you give it on input and throws it to an object of given type; I will
> need to construct arbitrary commits during the rebuild if I'm to keep
> the correct dates.)

Hah. That's what "COMMITTER_NAME" "COMMITTER_EMAIL" and "COMMITTER_DATE" 
are there for.

There's two things to commits: when (and by whom) it was committed to a
tree, and when the changes were really done.

So set the COMMITTER_xxx things to the person/time you want to consider 
the _original_ one, and let "commit-tree" author you as the creator of the 
commit itself. The regular "ChangeLog" thing should only show the author 
and original time, but it's nice to see who created the commit itself.

I did this very much on purpose: see how I always try to attribute 
authorship in BK to the person who actually wrote the code. At the same 
time, I think it's interesting from a tracking standpoint to also see 
when/where that change got introduced into a tree.

I _tried_ to get this right in the sparse tree conversion. I won't 
guarantee that it's all correct, but the top commit in the sparse tree 
looks like this:

	tree 67607f05a66e36b2f038c77cfb61350d2110f7e8
	parent 9c59995fef9b52386e5f7242f44720a7aca287d7
	author Christopher Li <sparse@xxxxxxxxxxx> Sat Apr  2 09:30:09 PST 2005
	committer Linus Torvalds <torvalds@xxxxxxxxxxxxxxx> Thu Apr  7 20:06:31 2005

	...

exactly because I tracked when I committed it to the sparse tree 
_separately_ from tracking when it was created.

So when I re-create the sparse-tree, I'll also end up re-writing the 
"committer" information. And that's proper. That's really saying "this 
sha1 object was created by Xxxx at time Xxxx".

Btw, the "COMMITTER_xxxx" environment variables are very confusingly
named. They actually go into the _author_ line in the commit object. I'm a
total retard, and I really don't know why I called it "COMMITTER_xxx"  
instead of "AUTHOR_xxx".

			Linus "retard" Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/