Re: [linux-dvb-maintainer] [2.6 patch] drivers/media/dvb/: possible cleanups

From: Johannes Stezenbach
Date: Wed Apr 20 2005 - 13:17:18 EST


On Tue, Apr 19, 2005 at 02:43:08AM +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 the following unused global functions:
> - dibusb/dvb-dibusb-usb.c: dibusb_set_streaming_mode
> - frontends/mt352.c: mt352_read
> - ttpci/av7110_hw.c: av7110_reset_arm
> - ttpci/av7110_hw.c: av7110_send_ci_cmd
> - remove the following unneeded EXPORT_SYMBOL:
> - frontends/mt352.c: mt352_read
>
> Please review which of these changes do make sense.

I'll apply this patch to linuxtv.org CVS.

Most cleanups look fine, except the dibusb driver
has been superseded by a generalized dvb-usb driver.
mt352_read() can be dropped completely.

Thanks,
Johannes
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/