Re: [PATCH 2.6.12-rc2] aoe [1/6]: improve allowed interfaces configuration

[Greg KH]

On Thu, Apr 21, 2005 at 11:30:06AM -0400, Ed L Cashin wrote:
> Greg KH <greg@xxxxxxxxx> writes:
> 
> > On Thu, Apr 21, 2005 at 09:36:17AM -0400, Ed L Cashin wrote:
> >> "Bodo Eggert <harvested.in.lkml@xxxxxxxxxxxxxxxxxxxxxxxxxx>" <7eggert@xxxxxx> writes:
> >> 
> >> > Ed L Cashin <ecashin@xxxxxxxxxx> wrote:
> >> >
> >> >> +++ b/Documentation/aoe/aoe.txt       2005-04-20 11:42:20.000000000 -0400
> >> >
> >> >> +  When the aoe driver is a module, use
> >> >
> >> > Is there any reason for this inconsistent behaviour?
> >> 
> >> Yes, the /sys/module/aoe area is only present when the aoe driver is a
> >> module.
> >
> > Not true, have you looked in /sys/module lately?  :)
> >
> >> It would be nicer if there were a sysfs area where I could
> >> put this file regardless of whether the driver is a module or built
> >> into the kernel.  
> >
> > That's the place for it.  It will be there if the driver is built as a
> > module or into the kernel.
> 
> Wow!  Well, that's very convenient for driver writers, so I'm pleased,
> and I can update the docs.  It surprises me, though, to find out that
> /sys/module is for things other than modules.

It's not for things other than modules, it's filling a real need that
you yourself just pointed out.  Namely, we need to be able to have
access to module paramaters in a consistant place, no matter if the
driver is built into the kernel or not.

Man, you try to be nice to people...  :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/