Re: [PATCH] fix include order in mthca_memfree.c
From: Al Viro
Date: Sun Apr 24 2005 - 23:05:16 EST
On Sun, Apr 24, 2005 at 07:31:18PM -0700, Roland Dreier wrote:
> - Out of curiousity, what arch and/or config requires <linux/mm.h>?
> I regularly cross-compile drivers/infiniband for i386, x86_64, ppc64,
> ia64, sparc64 and ppc, and I haven't needed <linux/mm.h> in mthca_memfree.c.
alpha, for instance. You are using lowmem_page_address(). That's
from linux/mm.h and that's an inline function, so missing include
FWIW, the chain of includes that leads to mm.h on i386 is mthca_memfree.h ->
linux/pci.h -> asm-i386/pci.h -> linux/mm.h. Other platforms differ...
> - When making changes to drivers/infiniband, can you please cc the
> maintainers or at least a public mailing list? As far as I can
> tell, the patch went directly to Linus with no public review, which
> doesn't seem appropriate, no matter how trivial the change.
> - When adding includes, please match the existing style and put
> <linux/xxx.h> includes before any local "yyy.h" includes.
Sure, no problem.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/