Re: [patch 7/7] uml ubd: handle readonly status

[Jens Axboe]

On Sun, Apr 24 2005, blaisorblade@xxxxxxxx wrote:
> @@ -1099,6 +1104,7 @@ static int prepare_request(struct reques
>  	if((rq_data_dir(req) == WRITE) && !dev->openflags.w){
>  		printk("Write attempted on readonly ubd device %s\n", 
>  		       disk->disk_name);
> +		WARN_ON(1); /* This should be impossible now */
>  		end_request(req, 0);
>  		return(1);
>  	}

I don't think that's a sound change. The WARN_ON() is strictly only
really useful for when you need the stack trace for something
interesting. As the io happens async, you will get a boring trace that
doesn't contain any valuable information.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/