Re: [PATCH] x86_64: handle iret faults better

[Linus Torvalds]

On Mon, 25 Apr 2005, Andi Kleen wrote:
> 
> But I really hate your is_iret hack in traps.c. 

I agree.

Why don't you just do

	pushl $0
	pushl $do_iret_error
	jmp error_code

And just have a "do_iret_error()" handler in traps.c which does the right
thing? That seems like the _sane_ thing to do, and that way there is never
any confusion about what is going on.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/