Re: [PATCH scsi-misc-2.6 01/04] scsi: make scsi_send_eh_cmnd useits own timer instead of scmd->eh_timeout

From: James Bottomley
Date: Mon Apr 25 2005 - 13:10:15 EST


On Mon, 2005-04-25 at 08:46 +0900, Tejun Heo wrote:
> If you're talking about scmd->eh_timeout, it's our main timer for
> normal command timeouts. If you're suggesting renaming it to something
> more apparant, I agree. Maybe just scmd->timeout will do.

Sorry ... actually on the ball now; I was assuming you simply wanted not
to use the field for efficiency.

So, actually having read the description, you think that reusing the
eh_timeout in the error handler command submission path could confuse
the normal done routine if the host still has the command pending and
completes it?

Jmaes


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/