Re: [PATCH 1b/7] dlm: core locking

[Nikita Danilov]

David Teigland writes:
 > 
 > The core dlm functions.  Processes dlm_lock() and dlm_unlock() requests.

[...]

 > +
 > +static int is_remote(struct dlm_rsb *r)
 > +{
 > +	DLM_ASSERT(r->res_nodeid >= 0, dlm_print_rsb(r););
 > +	return r->res_nodeid ? TRUE : FALSE;
 > +}

This can be simply

        return r->res_nodeid;

 > +
 > +static int is_master(struct dlm_rsb *r)
 > +{
 > +	return r->res_nodeid ? FALSE : TRUE;
 > +}

This duplicates dlm_is_master() for no obvious reason.

 > +
 > +int dlm_is_master(struct dlm_rsb *r)
 > +{
 > +	return r->res_nodeid ? FALSE : TRUE;
 > +}

This can be simply

        return !r->res_nodeid;

Nikita.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/