Re: [PATCH] hfsplus: don't oops on bad FS

[Jesper Juhl]

On Mon, 25 Apr 2005, Colin Leroy wrote:

> On 25 Apr 2005 at 21h04, Roman Zippel wrote:
> 
> Hi, 
> 
> > Actually it looks like we are always leaking it, so actually 
> > hfsplus_put_super() needs fixing, could you add the check and kfree 
> > there and do the same fix for hfs?
> 
> Mmh, right. Here's an updated version that fixes it too.
> 
> Signed-off-by: Colin Leroy <colin@xxxxxxxxxx>
> --- a/fs/hfsplus/super.c	2005-04-25 21:56:56.000000000 +0200
> +++ b/fs/hfsplus/super.c	2005-04-25 21:58:39.000000000 +0200
> @@ -226,6 +226,9 @@
>  	brelse(HFSPLUS_SB(sb).s_vhbh);
>  	if (HFSPLUS_SB(sb).nls)
>  		unload_nls(HFSPLUS_SB(sb).nls);
> +
> +	kfree((struct hfsplus_sb_info *)sb->s_fs_info);

kfree() takes a  void *  argument, that cast is not needed.


-- 
Jesper Juhl


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/