Re: [PATCH 5/7] dlm: device interface

From: Arjan van de Ven
Date: Mon Apr 25 2005 - 16:03:34 EST



> +static struct rw_semaphore lockinfo_lock;


why are you using a rwsem here? rw semaphores are *expensive*. Really
expensive. Might well not be worth it unless you expect really frequent
readers compared to writers *and* long hold times. Can you give an idea
about how frequent the reader case is?
(and if it's really frequent, wouldn't RCU be a better solution?)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/