Re: [PATCH] x86_64: handle iret faults better

[Linus Torvalds]

On Mon, 25 Apr 2005, Roland McGrath wrote:
> 
> 								   We want
>  * to turn it into a signal.  To make that signal's info exactly match what
>  * this same kind of fault in a user instruction would show, the fixup
>  * needs to know the trapno and error code.  But those are lost when we get
>  * back to the fixup entrypoint.  

Bah.

The _information_ is there, it's right on the stack-frame in the original 
CS/SS etc.

I'll take reliable and obvious code _any_ day over hacky code just to get 
me an "error code" for something that just isn't very interesting.

In other words, your code is not only ugly, it's also the kind of code 
that makes you go "how does that work". 

I think it's a lot more important that the kernel obviously work 
correctly.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/